-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparation for Packaging #5
Conversation
Hey @fuzhanrahmanian, I started this PR to make packaging of this project possible. I noticed that currently, the |
f3a5177
to
29bd845
Compare
I removed unused code from the alexnet file, so that the luna/luna/pretrained_models/googlenet.py Lines 433 to 434 in c71e518
and luna/luna/pretrained_models/models.py Line 76 in c71e518
, which are referring to static files. We should think about how to remove that in a future PR. |
Removed code for alexnet that was not used, and removed the weight specification of googlenet.
install_requires = | ||
tensorflow | ||
tf_slim | ||
keras |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is numpy not needed? (image.py uses it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think numpy is a dependency of TensorFlow, which is why it still works I assume. However, if we use it directly we should add it. I will do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except "NumPy" in the install requirements, the changes look good, thanks!
Describe your improvements
Started packaging process by changing the project structure and defining the setup configuration.
To Reproduce
Follow the steps outlined in the README.md.