Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update preconditioning #34

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Update preconditioning #34

merged 1 commit into from
Dec 8, 2021

Conversation

fuzhanrahmanian
Copy link
Collaborator

  • Corrected image initialization

Sparkier
Sparkier requested changes Dec 6, 2021
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
@Sparkier Sparkier force-pushed the update_optimizer branch 2 times, most recently from bdda761 to 920663f Compare December 6, 2021 10:56
@Sparkier
Copy link
Owner

Sparkier commented Dec 8, 2021

@fuzhanrahmanian I do not know which changes are still relevant. Can you tell me which commit is the one we want to have from this PR? A lot of them have been addressed in other PRs.

Base automatically changed from update_optimizer to master December 8, 2021 09:53
@fuzhanrahmanian
Copy link
Collaborator Author

@fuzhanrahmanian I do not know which changes are still relevant. Can you tell me which commit is the one we want to have from this PR? A lot of them have been addressed in other PRs.

Just the changes to images.py are relevant

@fuzhanrahmanian fuzhanrahmanian merged commit 89097b7 into master Dec 8, 2021
@fuzhanrahmanian fuzhanrahmanian deleted the update_preconditioning branch December 8, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sparkier Sparkier Sparkier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuzhanrahmanian @Sparkier