Updating transformations #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fuzhanrahmanian
commented
Dec 4, 2021
fuzhanrahmanian
commented
- New Transformation: divided into transformations and auxiliary transformations
- Added the option for custom transformations dictionaries
- Added the option for a "standard" transformation (as suggested by lucid)
Sparkier
requested changes
Dec 6, 2021
luna/featurevis/transformations.py
Outdated
| return img | ||
|
|
||
|
|
||
| def perform_trans(img, trans_param): |
There was a problem hiding this comment.
This should have another name. Why does this preset exist?
There was a problem hiding this comment.
I changed the name of the variable to trans_func (after functionalizing the input). What exactly do you mean by "preset"?
Right now, this variable would be a function.
…sformations * Added the option for custom transformations dictionaries * Added the option for a "standard" transformation (as suggested by lucid)
* Removed reduntant bools from transformation functions
fuzhanrahmanian
force-pushed
the
update_transformation
branch
from
2ada1f1
to
bf92e09
Compare
Sparkier
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.