The import for conv_utils does not work. #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fuzhanrahmanian
commented
Oct 16, 2021
fuzhanrahmanian
commented
- Update to import the function from tensorflow.python.keras.utils
* Update to import the function from tensorflow.python.keras.utils
Sparkier
reviewed
Oct 19, 2021
Sparkier
requested changes
Oct 21, 2021
| @@ -445,7 +445,7 @@ def create_googlenet(user_weight_path=None): | |||
| for layer in googlenet.layers: | |||
| if layer.__class__.__name__ == 'Conv2D': | |||
| original_w = tf.compat.v1.keras.backend.get_value(layer.kernel) | |||
| converted_w = convert_kernel(original_w) | |||
| converted_w = conv_utils(original_w) | |||
There was a problem hiding this comment.
Can you provide a code snipped that shows if that works? I am still not sure this is correct.
Would like to reproduce before merging.
There was a problem hiding this comment.
I tried it on collaboratory and it seems to work
There was a problem hiding this comment.
Or at least i runs :)
Sparkier
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.