Skip to content

Conversation

tcrawford-SP
Copy link
Contributor

Added the "How many IP's do I need" section.

// Give your PR a recognizable title. For example: "FE-123: Add new prop to component" or "Resolve Issue #123: Fix bug in component" // Your PR title will be visible in changelogs

What Changed

// What changes does this PR propose? // Provide screenshots or screen recordings for any visual changes.

How To Test or Verify

// Describe any steps that may help reviewers verify changes. // Anything beyond basic unit testing, such as assistive tech usage, or special interactions.

PR Checklist

Below are some checklists to follow for the correct procedure in different circumstance. The first list ("All PRs Checklist") should be followed for ALL PRs. The next 2 are additive to this list depending on what type of PR you are using.

For example: If you are submitting a content change to one of the support documents, your checklist would include the:

  • "All PRs Checklist"
  • AND the "Content Changes Checklist

If you are submitting a feature addition, enhancement, or bug fix, your checklist would include the:

  • "All PRs Checklist"
  • AND the "Development Changes Checklist"

All PRs Checklist

  • Give your pull request a meaningful name.
  • Use lowercase filenames.
  • Pull request approval from the FE team or content experts that isn't the content creator.

Content Changes Checklist

  • Check that your article looks correct in the preview here or in a Netlify deploy preview.
  • Check the links in your article.
  • Check the images in your article (if there are any)
  • Check to make sure you are using markdown appropriately as outlined in examples/article.md in the root of the project directory and on the momentum doc's preface article
  • Check to make sure the Copy and Tone Guidelines are followed.

Development Changes Checklist (some checks are automatic github actions and will not be listed here. ie. "all tests pass")

  • The appropriate tests are created in cypress/ directory in the root of the project
  • The lighthouse score is passing according to the FE Support Docs' Service Outline SLI/SLOs

Added the "How many IP's do I need" section.
@netlify
Copy link

netlify bot commented Dec 21, 2021

‼️ Deploy request for support-docs rejected.

Learn more about Netlify's sensitive variable policy

Name Link
🔨 Latest commit a3d47ed

@tcrawford-SP
Copy link
Contributor Author

Brian is going to give me write permission.

@tcrawford-SP tcrawford-SP deleted the patch-1 branch December 21, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant