Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flytter dm-variabler inn til theme, header #2272

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

tuva-odegard
Copy link
Contributor

@tuva-odegard tuva-odegard commented Sep 9, 2024

Ifbm. semantiske verdier flytter vi varibler som har med darkmode ut.
Dette er for header.

Header var fra før av ganske lite darkmode-vennlig. Det er gjort noen justeringer for å få bedre kontraster, men det gjenstår fortsatt et arbeid med å få darkmode til å se bra ut.

Styling av linker i component-overview på (https://sparebank1.github.io/designsystem/) overskriver her noe av stilen i darkmode, @pethel skal se på om vi finner en løsning som fungerer for begge.

fixes #2235

Copy link

github-actions bot commented Sep 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2272.westeurope.2.azurestaticapps.net

@pethel
Copy link
Contributor

pethel commented Sep 9, 2024

Er denne lite teksten lite mørk?
image

--ffe-v-usernav-link-hover-background-color: var(--ffe-farge-frost-30);
--ffe-v-usernav-link-focus-background-color: var(--ffe-farge-frost-30);
--ffe-v-usernav-list-border-color: var(--ffe-farge-vann);
--ffe-v-logout-button-label-color-text: var(--ffe-farge-vann-30);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det her var fra meg ja. Brannslukkning bare :)

pethel
pethel previously approved these changes Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2272.westeurope.2.azurestaticapps.net

1 similar comment
Copy link

github-actions bot commented Sep 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2272.westeurope.2.azurestaticapps.net

Copy link

github-actions bot commented Sep 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2272.westeurope.2.azurestaticapps.net

2 similar comments
Copy link

github-actions bot commented Sep 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2272.westeurope.2.azurestaticapps.net

Copy link

github-actions bot commented Sep 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2272.westeurope.2.azurestaticapps.net

@tuva-odegard tuva-odegard merged commit 1d0b6d6 into develop Sep 9, 2024
3 checks passed
@tuva-odegard tuva-odegard deleted the darkmode-header branch September 9, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flytte darkmode-variabler til theme.less - Header
2 participants