-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Node v6.10 API compatibility #2
Conversation
Reviewed 14 of 22 files at r1, 8 of 8 files at r2. a discussion (no related file): Once builds are passing I'll give a final look and squirrel. src/index.js, line 90 at r2 (raw file):
I've always preferred the format src/index.js, line 222 at r2 (raw file):
BTW - TIL what a surrogate pair was 🙃 Comments from Reviewable |
Reviewed 16 of 22 files at r1. src/index.js, line 90 at r2 (raw file): Previously, pcgilday (Patrick Gilday) wrote…
as indicated in the comment at the top of this file, this is copied from node source https://github.com/nodejs/node/blob/v6.10.2/lib/querystring.js plus this isn't just a matter of style/taste, prefix is a different operation than postfix https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Arithmetic_Operators#Increment_() Comments from Reviewable |
Reviewed 2 of 22 files at r1, 6 of 8 files at r2, 1 of 3 files at r3, 2 of 2 files at r4. Comments from Reviewable |
BREAKING CHANGE: This is a complete rewrite based upon the actual node source code and tests.
This change is