-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly resolve relative paths in CSS imports #527
Properly resolve relative paths in CSS imports #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to contributing to WebCord!
I overall think the code introduces a lot of redundancy, I won't pull this until either you or I will resolve them. Also, it touches some irrelevant pieces of the code [comparing] to the overall topic of this PR, I guess explaining your approach a bit more and why you haven't considered the others would help me understand your intentions.
3b5e51d
to
e4beaf6
Compare
e4beaf6
to
4148b5c
Compare
You don't have to force-push PR on changes to have a specific history, in fact it might be better to commit on top of the another. As long as things are around single thing to be implemented, I can always squash your commits later, and having the history of changes done to this PR is for sure useful if we consider to go back to how things were before (isn't that main purpose of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still need to resolve some things before I will be willing to pull it (I've made new comments around that).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉.
Currently, WebCord cannot resolve relative imports because it simply constructs a
new URL()
with the relative URL which will fail.This change passes context about the current file to
parseImports
andfetchOrRead
to prepend the previous URL's directory name if creating a URL fails.