Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google and Letterboxd support #20

Closed
wants to merge 3 commits into from
Closed

Conversation

mofman
Copy link

@mofman mofman commented Dec 27, 2016

No description provided.

@mofman mofman mentioned this pull request Dec 27, 2016
6 tasks
@SpaceK33z
Copy link
Owner

Ah, I know why it can't find the movies on Plex for Letterboxd. They use a special space character instead of a "normal" space. The query is this ?query=Being%20John%C2%A0Malkovich while it should be ?query=Being%20John%20Malkovich.

I've fixed this in master, see db59b00.

@mofman
Copy link
Author

mofman commented Dec 27, 2016

@SpaceK33z Good eye! Sweet, those seems to be working okay but feel free to refactor as much as you want.

They still need styling which might be best for you to do as I'm not great at front end.
Also need to match all google domains in the manifest.json, https://www.google.*/* seems to fail?

@SpaceK33z
Copy link
Owner

Allright I'll do the styling. It can take some time before I get to it though.

About the google domains thingy, it seems like Chrome doesn't want to make a feature to make it easy to match all those domains. See this issue and this one.

@SpaceK33z
Copy link
Owner

@mofman a full year later and I finally implemented Letterboxd support based on your PR 😶. I couldn't merge the full PR because the Google functionality is not ready yet. But thanks, this really saved much time! I only had to tweak some small things, mostly styling.

@Ephellon Ephellon changed the title Beginning google and letterbox functionality Google and Letterboxd support Nov 14, 2018
@Ephellon
Copy link
Collaborator

I've added your changes to the 4.0 update @mofman 🥇

@Ephellon Ephellon closed this Nov 14, 2018
@mofman
Copy link
Author

mofman commented Nov 14, 2018

nice work @Ephellon & @SpaceK33z!

@Ephellon Ephellon added the enhancement this item makes the project better in some way label Jun 28, 2019
@Ephellon Ephellon self-assigned this Jun 28, 2019
This was referenced Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement this item makes the project better in some way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants