Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: My Shows doesn't work #120

Closed
Ephellon opened this issue Nov 29, 2019 · 3 comments
Closed

Issue: My Shows doesn't work #120

Ephellon opened this issue Nov 29, 2019 · 3 comments
Assignees
Labels
bug this item causes errors that make the project unusable enhancement this item makes the project better in some way help-wanted outside assistance is recommended for this item

Comments

@Ephellon
Copy link
Collaborator

Ephellon commented Nov 29, 2019

Describe the error
The plugin for My Shows doesn't work correctly.

To Reproduce
Steps to reproduce the behavior:

  1. Enable My Shows
  2. Go to My Shows
  3. Choose a TV series

Estimated location
0U C7P

Screenshots
image

Extension Information

  • Version: 4.0
  • Source: GitHub
  • Browser: chrome firefox

Additional comments
The plugin starts correctly, but doesn't go on after requesting the PLUGIN update event. It also never logs the UTILS_TERMINAL state as all other sites do (with DEVELOPER_MODE enabled).

@Ephellon Ephellon added bug this item causes errors that make the project unusable enhancement this item makes the project better in some way help-wanted outside assistance is recommended for this item labels Nov 29, 2019
@Ephellon Ephellon self-assigned this Nov 29, 2019
@Ephellon
Copy link
Collaborator Author

Ephellon commented Dec 2, 2019

If you will support TV shows and Sonarr in the future, I would love to have support for the myshows.me website (Russian Trakt.tv alternative for TV shows). For example: https://en.myshows.me/view/5713/
Shows pages can have urls in those formats:

https://en.myshows.me/view/5713/
https://myshows.me/view/5713/
https://ua.myshows.me/view/5713/

and every show page has an IMDB link, located here:

$("div.clear>p:nth-child(9)>a")[0].href

Name:
for pages 'https://myshows.me/ *': $("p.subHeader")[0].innerText
for pages 'https://**.myshows.me/ *': $("main>h1")[0].innerText (needs to remove extra space at the end of the result)

Year (needs regex for first 4-letter number):

$("div.clear>p.flat")[0].innerText

If this data is enough for the website support, I'll try to make a pull request if/when the TV support will be added.

Originally posted by @enchained in #14.357043855

@Ephellon
Copy link
Collaborator Author

Ephellon commented Dec 18, 2019

Found problem, TLDs are blocked off... will find a workaround:

utils.js 0U:1044 v4.1.1.5

if(configuration) {
	let host = location.host.replace(/^(ww\w+\.)/, ''),
			// ^ww\w+ - the problem, as myshows uses `\w{2}.myshows.me/...`
		doms = configuration.__domains.split(',');

	if(!~doms.indexOf(host))
		return;
}

@Ephellon
Copy link
Collaborator Author

Ephellon commented Dec 18, 2019

/* location.host.split('.').reverse().slice(0, 2).reverse().join('.') */
host.replace(/^(ww\w+|\w{2})\./, '')

Ephellon added a commit to Ephellon/web-to-plex that referenced this issue Dec 18, 2019
Ephellon added a commit to Ephellon/web-to-plex that referenced this issue Dec 18, 2019
This was referenced Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug this item causes errors that make the project unusable enhancement this item makes the project better in some way help-wanted outside assistance is recommended for this item
Projects
None yet
Development

No branches or pull requests

1 participant