Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom serde serialization for DefaultPublicKey #962

Merged
merged 11 commits into from
Oct 2, 2023
Merged

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Sep 30, 2023

Description

This PR introduces custom serde serialization and deserialization for the DefaultPublicKey type. This means that the public key can now be automatically serialized as hexadecimal without requiring manual conversion to DefaultPublicKeyHex

Testing

Unit test added.

Docs

No changes.

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #962 (6f43dc0) into nightly (f31359e) will increase coverage by 0.1%.
The diff coverage is 92.5%.

❗ Current head 6f43dc0 differs from pull request most recent head e476fd5. Consider uploading reports for the commit e476fd5 to get more accurate results

Files Coverage Δ
...module-implementations/sov-accounts/src/genesis.rs 95.0% <100.0%> (-0.3%) ⬇️
...m/module-implementations/sov-accounts/src/hooks.rs 96.2% <100.0%> (ø)
...m/module-implementations/sov-accounts/src/tests.rs 99.5% <100.0%> (ø)
...le-system/sov-modules-api/src/default_signature.rs 76.2% <100.0%> (ø)
module-system/sov-modules-api/src/lib.rs 91.3% <ø> (ø)
module-system/sov-modules-api/src/pub_key_hex.rs 93.3% <100.0%> (+5.3%) ⬆️
...tem/module-implementations/sov-accounts/src/lib.rs 72.7% <0.0%> (ø)
module-system/sov-modules-api/src/serde_pub_key.rs 91.4% <91.4%> (ø)

... and 2 files with indirect coverage changes

@bkolad bkolad changed the title Custo serde serialization for DefaultPublicKey Custom serde serialization for DefaultPublicKey Sep 30, 2023
@bkolad bkolad marked this pull request as ready for review October 2, 2023 06:00
@bkolad bkolad requested a review from neysofu October 2, 2023 07:33
Copy link
Member

@neysofu neysofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have just added a comment about AccountConfig generics. Feel free to either address or ignore and merge.

@bkolad bkolad added this pull request to the merge queue Oct 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2023
@bkolad bkolad enabled auto-merge October 2, 2023 08:17
@bkolad bkolad added this pull request to the merge queue Oct 2, 2023
Merged via the queue into nightly with commit 4f4e27e Oct 2, 2023
11 checks passed
@bkolad bkolad deleted the blaze/pub_key_serde branch October 2, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants