-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom serde serialization for DefaultPublicKey #962
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have just added a comment about AccountConfig
generics. Feel free to either address or ignore and merge.
Description
This PR introduces custom serde serialization and deserialization for the
DefaultPublicKey
type. This means that the public key can now be automatically serialized as hexadecimal without requiring manual conversion toDefaultPublicKeyHex
Testing
Unit test added.
Docs
No changes.