Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValueSetter module: read genesis config from a file. #901

Merged
merged 4 commits into from
Sep 20, 2023
Merged

ValueSetter module: read genesis config from a file. #901

merged 4 commits into from
Sep 20, 2023

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Sep 20, 2023 •
edited
Loading

Description

Read genesis configuration for ValueSetter module from a file rather than having these values hard-coded in the code.
Once this approach has been reviewed and approved, we have two tasks to complete:

  1. Make the same change for all the modules
  2. Pass all the required paths (for all modules) as parameters to the get_genesis_config

Linked Issues

Testing

CI passes.

Docs

No doc changes

@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #901 (2263aa1) into nightly (8d04bc6) will increase coverage by 0.0%.
The diff coverage is n/a.

see 2 files with indirect coverage changes

@bkolad bkolad changed the title WIO test_config_serialization WIP test_config_serialization Sep 20, 2023
@bkolad bkolad changed the title WIP test_config_serialization ValueSetter module: read genesis config from a file. Sep 20, 2023
@bkolad bkolad requested review from citizen-stig and preston-evans98 and removed request for citizen-stig September 20, 2023 09:02
@bkolad bkolad marked this pull request as ready for review September 20, 2023 09:02
@bkolad bkolad added this pull request to the merge queue Sep 20, 2023
Merged via the queue into nightly with commit 30ea4c5 Sep 20, 2023
13 checks passed
@bkolad bkolad deleted the blaze/genesis_value_setter branch September 20, 2023 17:33
@citizen-stig citizen-stig linked an issue Sep 26, 2023 that may be closed by this pull request
Remove hardcoded genesis values and instead read the genesis configuration of a rollup from files. #872
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizen-stig citizen-stig citizen-stig approved these changes

@preston-evans98 preston-evans98 Awaiting requested review from preston-evans98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove hardcoded genesis values and instead read the genesis configuration of a rollup from files.
2 participants
@bkolad @citizen-stig