Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: remove collect from get_block_by_number query. #898

Merged
merged 1 commit into from
Sep 20, 2023
Merged

EVM: remove collect from get_block_by_number query. #898

merged 1 commit into from
Sep 20, 2023

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Sep 19, 2023 •
edited
Loading

Description

Removes unnecessary collect.

Linked Issues

  • Fixes # (issue, if applicable)
  • Related to # (issue)

Testing

Describe how these changes were tested. If you've added new features, have you added unit tests?

Docs

Describe where this code is documented. If it changes a documented interface, have the docs been updated?

@bkolad bkolad marked this pull request as ready for review September 19, 2023 14:58
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #898 (8063378) into nightly (0259c64) will increase coverage by 0.0%.
The diff coverage is 0.0%.

Files Changed Coverage Δ
...system/module-implementations/sov-evm/src/query.rs 0.0% <0.0%> (ø)

... and 1 file with indirect coverage changes

@bkolad bkolad added this pull request to the merge queue Sep 20, 2023
Merged via the queue into nightly with commit cc1ddab Sep 20, 2023
13 checks passed
@bkolad bkolad deleted the blaze/evm_ramove_collect branch September 20, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dubbelosix dubbelosix dubbelosix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkolad @dubbelosix