Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify genesis initialization #888

Merged
merged 18 commits into from
Sep 19, 2023
Merged

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Sep 18, 2023

Description

This PR makes get_genesis_config as the exclusive method for generating a GenesisConfig. Prior to this change, tests/benchmarks and prover relied on the internal details of genesis_config.rs.

Currently, the code contains hard-coded paths to the token_deployer private key and genesis values for all modules. However, these hard-coded values will be updated in the upcoming PRs.

Linked Issues

Testing

CI passes

Docs

No doc changes.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #888 (27e7cbc) into nightly (e68cc2e) will not change coverage.
The diff coverage is 100.0%.

Files Changed Coverage Δ
...tions/integration-tests/src/chain_state/helpers.rs 100.0% <100.0%> (ø)
...tations/integration-tests/src/chain_state/tests.rs 97.0% <100.0%> (ø)

@bkolad bkolad changed the title WIP: Genesis Initialization Unify genesis initialization Sep 19, 2023
@bkolad bkolad marked this pull request as ready for review September 19, 2023 12:09
@preston-evans98 preston-evans98 added this pull request to the merge queue Sep 19, 2023
Merged via the queue into nightly with commit 9b9b027 Sep 19, 2023
13 checks passed
@preston-evans98 preston-evans98 deleted the blaze/modules_init_refactor branch September 19, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants