Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FinalizeSlotHook and invoke it after genesis #870

Merged
merged 17 commits into from
Sep 18, 2023

Conversation

LukaszRozmej
Copy link
Contributor

@LukaszRozmej LukaszRozmej commented Sep 14, 2023

Description

Separates SlotHooks and FinalizeSlotHook as they have different context. Invoke FinalizeSlotHook after normal slots as well as genesis.

Linked Issues

Testing

Integration tests

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #870 (ecb06dc) into nightly (f662415) will decrease coverage by 1.6%.
The diff coverage is 84.6%.

Files Changed Coverage Δ
...odule-implementations/sov-chain-state/src/hooks.rs 87.7% <ø> (ø)
...system/module-implementations/sov-evm/src/hooks.rs 95.7% <60.0%> (-4.3%) ⬇️
...tions/integration-tests/src/chain_state/helpers.rs 100.0% <100.0%> (ø)
...ule-implementations/sov-evm/src/evm/conversions.rs 98.9% <100.0%> (+<0.1%) ⬆️
...stem/module-implementations/sov-evm/src/evm/mod.rs 100.0% <100.0%> (ø)
...stem/module-implementations/sov-evm/src/genesis.rs 100.0% <100.0%> (+1.2%) ⬆️
module-system/sov-modules-stf-template/src/lib.rs 85.5% <100.0%> (+0.8%) ⬆️

... and 17 files with indirect coverage changes

@LukaszRozmej LukaszRozmej marked this pull request as ready for review September 18, 2023 10:42
@LukaszRozmej LukaszRozmej added this pull request to the merge queue Sep 18, 2023
Merged via the queue into nightly with commit 118f196 Sep 18, 2023
12 of 13 checks passed
@LukaszRozmej LukaszRozmej deleted the lukasz/FinalizeSlotHook branch September 18, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EVM: Seperate finalized_slot hook, called after genesis and normal slots
2 participants