Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test demo-rollup commands in CI #851

Merged
merged 8 commits into from
Sep 19, 2023
Merged

Test demo-rollup commands in CI #851

merged 8 commits into from
Sep 19, 2023

Conversation

neysofu
Copy link
Member

@neysofu neysofu commented Sep 13, 2023

To generate the script:

$ cargo run --bin bashtestmd -- --input examples/demo-rollup/README.md --output script.sh --tag test-ci

Then, chmod +x script.sh and run with ./script.sh.

I will remove script.sh and update CI workflows if approved, but I'm leaving the script committed to facilitate reviews for now.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #851 (983e1d8) into nightly (d9e2075) will decrease coverage by 0.9%.
The diff coverage is 0.0%.

Files Changed Coverage Δ
utils/bashtestmd/src/main.rs 0.0% <0.0%> (ø)

... and 1 file with indirect coverage changes

Signed-off-by: Filippo Costa <[email protected]>
Signed-off-by: Filippo Costa <[email protected]>
@neysofu neysofu changed the title [WIP] Test demo-rollup commands in CI Test demo-rollup commands in CI Sep 15, 2023
@neysofu neysofu marked this pull request as ready for review September 15, 2023 13:09
script.sh Outdated Show resolved Hide resolved
Copy link
Member

@preston-evans98 preston-evans98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should we add this into CI?

@neysofu
Copy link
Member Author

neysofu commented Sep 19, 2023

Done! Merging.

@neysofu neysofu added this pull request to the merge queue Sep 19, 2023
Merged via the queue into nightly with commit e68cc2e Sep 19, 2023
13 checks passed
@neysofu neysofu deleted the filippo/bashtest branch September 19, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants