Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base64 requirement from 0.13.1 to 0.21.2 #532

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 19, 2023

Updates the requirements on base64 to permit the latest version.

Changelog

Sourced from base64's changelog.

0.21.2

  • Rollback MSRV to 1.57.0 -- only dev dependencies need 1.60, not the main code

0.21.1

  • Remove the possibility of panicking during decoded length calculations
  • DecoderReader no longer sometimes erroneously ignores padding #226

Breaking changes

  • Engine.internal_decode return type changed
  • Update MSRV to 1.60.0

0.21.0

Migration

Functions

< 0.20 function 0.21 equivalent
encode() engine::general_purpose::STANDARD.encode() or prelude::BASE64_STANDARD.encode()
encode_config() engine.encode()
encode_config_buf() engine.encode_string()
encode_config_slice() engine.encode_slice()
decode() engine::general_purpose::STANDARD.decode() or prelude::BASE64_STANDARD.decode()
decode_config() engine.decode()
decode_config_buf() engine.decode_vec()
decode_config_slice() engine.decode_slice()

The short-lived 0.20 functions were the 0.13 functions with config replaced with engine.

Padding

If applicable, use the preset engines engine::STANDARD, engine::STANDARD_NO_PAD, engine::URL_SAFE, or engine::URL_SAFE_NO_PAD. The NO_PAD ones require that padding is absent when decoding, and the others require that canonical padding is present .

If you need the < 0.20 behavior that did not care about padding, or want to recreate < 0.20.0's predefined Configs precisely, see the following table.

0.13.1 Config 0.20.0+ alphabet encode_padding decode_padding_mode
STANDARD STANDARD true Indifferent
STANDARD_NO_PAD STANDARD false Indifferent
URL_SAFE URL_SAFE true Indifferent
URL_SAFE_NO_PAD URL_SAFE false Indifferent

... (truncated)

Commits
  • 1e8246a v0.21.2
  • 13690af Merge pull request #239 from marshallpierce/mp/msrv
  • 02af00a Roll back MSRV to 1.57.0
  • 09c7907 Remove readme comments about benches needing nightly
  • f589cde Merge pull request #238 from marshallpierce/mp/decoder-reader-padding
  • 57e2334 Fix DecoderReader handling of padding
  • f766bc6 Merge pull request #223 from marshallpierce/mp/add_padding_len
  • 9687b03 Switch add_padding() to use encoded len
  • 29ed4d0 Merge pull request #217 from marshallpierce/mp/decode-estimate
  • 453d15d Update release notes
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 19, 2023
Updates the requirements on [base64](https://github.com/marshallpierce/rust-base64) to permit the latest version.
- [Changelog](https://github.com/marshallpierce/rust-base64/blob/master/RELEASE-NOTES.md)
- [Commits](marshallpierce/rust-base64@v0.13.1...v0.21.2)

---
updated-dependencies:
- dependency-name: base64
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/base64-0.21.2 branch from c6092bf to 2953dfc Compare July 19, 2023 13:11
@bkolad bkolad added the Small Use this label for quick cleanup and maintenance tasks label Jul 19, 2023
@citizen-stig citizen-stig self-assigned this Jul 19, 2023
@citizen-stig
Copy link
Member

I digged deeper into issues in base64 repo and managed to get similar behaivour in our crate. I believe it should be sufficient before jupiter refactoring is addressed.

Nice bonus, removed unsafe

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #532 (324643a) into nightly (ef12744) will increase coverage by 0.0%.
The diff coverage is 28.5%.

Impacted Files Coverage Δ
adapters/celestia/src/celestia.rs 60.6% <0.0%> (ø)
adapters/celestia/src/da_service.rs 62.3% <0.0%> (ø)
adapters/celestia/src/types.rs 0.0% <0.0%> (ø)
adapters/celestia/src/shares.rs 46.1% <50.0%> (+<0.1%) ⬆️

... and 6 files with indirect coverage changes

@citizen-stig citizen-stig merged commit d18081e into nightly Jul 20, 2023
10 of 11 checks passed
@citizen-stig citizen-stig deleted the dependabot/cargo/base64-0.21.2 branch July 20, 2023 13:50
preston-evans98 pushed a commit that referenced this pull request Sep 14, 2023
* Update base64 requirement from 0.13.1 to 0.21.2

Updates the requirements on [base64](https://github.com/marshallpierce/rust-base64) to permit the latest version.
- [Changelog](https://github.com/marshallpierce/rust-base64/blob/master/RELEASE-NOTES.md)
- [Commits](marshallpierce/rust-base64@v0.13.1...v0.21.2)

---
updated-dependencies:
- dependency-name: base64
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix base64 upgrade and remove unsafe

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nikolai Golub <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Small Use this label for quick cleanup and maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants