Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] cmd + click open new blank tab #412

Closed
weblancaster opened this issue Oct 14, 2015 · 3 comments
Closed

[Bug] cmd + click open new blank tab #412

weblancaster opened this issue Oct 14, 2015 · 3 comments
Assignees
@weblancaster
Labels
bug

Comments

@weblancaster
Copy link
Member

A friend discovered that when cmd + click just like in the browser, Soundnode App actually opens a new blank tab that is because it's a single page app (running on a browser) and the path is the local user.

Anyway.. to fix just "preventDefault" on cmd + click.
@jakejarrett
Copy link
Member

Also affects linux if you control + click. Should affect windows too.

@weblancaster
Copy link
Member Author

Yep

@ghost
Copy link

ghost commented Oct 23, 2015

@jakejarrett yes, affects windows too, just verified that ;-)

@weblancaster weblancaster self-assigned this Oct 23, 2015
weblancaster added a commit that referenced this issue Oct 23, 2015
@weblancaster
Merge pull request #419 from Soundnode/fix-412
9dca56e 
fix #412. add preventDefault when cmd(ctrl) + click is triggered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weblancaster weblancaster

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weblancaster @jakejarrett