Skip to content

fix: removed inkwell for web version #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imGok wants to merge 1 commit into from
Closed

fix: removed inkwell for web version #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 8 additions & 21 deletions lib/link_text.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ library matrix_link_text;

import 'dart:math';

import 'package:flutter/foundation.dart';
import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:url_launcher/url_launcher.dart';
Expand Down Expand Up @@ -310,26 +309,14 @@ TextSpan LinkTextSpans(
}
final uri = Uri.tryParse(link);
if (valid && uri != null) {
if (kIsWeb) {
// on web recognizer in TextSpan does not work properly, so we use normal text w/ inkwell
textSpans.add(
WidgetSpan(
child: InkWell(
onTap: () => launchUrlIfHandler(uri),
child: Text(linkText, style: linkStyle),
),
),
);
} else {
textSpans.add(
LinkTextSpan(
text: linkText,
style: linkStyle,
url: uri,
onLinkTap: launchUrlIfHandler,
),
);
}
textSpans.add(
LinkTextSpan(
text: linkText,
style: linkStyle,
url: uri,
onLinkTap: launchUrlIfHandler,
),
);
} else {
textSpans.add(TextSpan(text: linkText, style: textStyle));
}
Expand Down