-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oauth2 ver. 1.x already be EOL #317
Comments
The plan is to deprecate the custom OAuth implementations entirely for Sorcery v1 (by moving to using OmniAuth). |
Any info when we could hope for a release of v1? |
Maintainer of Oauth2 here. Oauth2 v1.x will be EOL in April 2023! Upgrading to v2 isn't hard for most use cases. Can the version restriction be loosened, so people can test with v2 before the release of sorcery v1.0? |
@pboling What are the breaking changes? If it's not too much of an overhaul, I can patch Sorcery v0 in the meantime. Apologies if there's already documentation on this; I'm at a work conference and don't have time to dig super deep right now. |
That looks like a lot, but I've not seen many reports of issues with upgrading, and I suspect most people don't have to change anything. |
I'll see if I can take a stab at this next week. |
@joshbuker So great!!! Thank you! |
@joshbuker ... I just noticed the OAuth 1 support relies on the
This will allow people using Ruby 2.7+ to have the latest version 1.1.x, and people stuclk on Ruby 2.4 will get the latest 0.6.x series release (both are actively maintained). There are a number of bug fixes in both, and I'm not aware of any breaking changes. |
IIRC, Edit: Oh, but yes this would prevent them from using |
No description provided.
The text was updated successfully, but these errors were encountered: