BUILD-6160 emptyJavadoc #1093
Merged
BUILD-6160 emptyJavadoc #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5120fed.
As of maven-javadoc-plugin 3.10.0, the empty Javadoc is generated by default
julien-carsique-sonarsource
requested a review
from kirill-knize-sonarsource
kirill-knize-sonarsource
approved these changes
Sep 3, 2024
|
kirill-knize-sonarsource
deleted the
fix/jcarsique/BUILD-6160-emptyJavadoc
branch
kirill-knize-sonarsource
added a commit
that referenced
this pull request
Oct 21, 2024
This reverts commit 27d459b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUILD-6160
Proper fix to the broken promotion.
The breakage was due to duplicated Javadoc artifacts generated and attached to the build.
As of maven-javadoc-plugin 3.10.0, the empty Javadoc is generated by default.
As suggested in apache/maven-javadoc-plugin#65 by the following sentence:
maven-javadoc-plugin 3.10.0 defaults to true, with no customization property.
This fix was confirmed by https://cirrus-ci.com/build/5445574646824960