USER-1011 False Negative with java:S2698 for org.testng #5302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardo-pilastri-sonarsource
requested a review
from tomasz-tylenda-sonarsource
|
|
||
| class AssertionsWithoutMessageCheckSample { | ||
| void foo() { | ||
| org.testng.Assert.assertTrue(true); // Noncompliant |
There was a problem hiding this comment.
I changed it to org.testng.Assert.assertTrue(true, "message"); // Noncompliant and it still passes. I guess that's because the messages in testng are the last parameter.
|
leonardo-pilastri-sonarsource
requested a review
from tomasz-tylenda-sonarsource
| } | ||
| } | ||
|
|
||
| private static boolean expectedMessageArgIsNotString(MethodInvocationTree mit, Type type) { |
There was a problem hiding this comment.
I tried to clean it up: I'd avoid negatives in method names and do ! where it is callled, conditional expression, so that variables don't change, also checking index < size is more idiomatic IMO. Wdyt?
/**
* True if the call has a message argument. Such an argument is a string
* and it is the first of the last argument (depending on the assertion library).
*/
private static boolean hasMessageArg(MethodInvocationTree mit, Type type) {
int expectedMessageArgIndex = (type.is("org.testng.Assert") || type.is("org.testng.AssertJUnit")) ? 1 : 0;
List<ExpressionTree> args = mit.arguments();
return expectedMessageArgIndex < args.size() && isString(args.get(expectedMessageArgIndex));
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USER-1011
Part of