Repository navigation
SONARJAVA-1217 Rule: Multiple loops over the same set - #353
Merged
Merged
Conversation
mpaladin
force-pushed
the
SONARJAVA-1217
branch
3 times, most recently
from
August 14, 2015 07:28
3a690c0 to
9394816
Compare
There was a problem hiding this comment.
Instead of casting to a JavaTree to get the line , preferably use node.identifierToken().line() as it will improve the efficiency.
mpaladin
force-pushed
the
SONARJAVA-1217
branch
3 times, most recently
from
August 17, 2015 15:40
cfc04d4 to
771b3b7
Compare
mpaladin
force-pushed
the
SONARJAVA-1217
branch
from
August 18, 2015 12:18
771b3b7 to
f20fe8e
Compare
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://jira.sonarsource.com/browse/SONARJAVA-1217