Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong Rule ID in ITS' expected rules #164

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Fix wrong Rule ID in ITS' expected rules #164

merged 2 commits into from
Jun 15, 2023

Conversation

loris-s-sonarsource
Copy link
Contributor

Loggers should be "private static const" and should share naming convention is S1312, not S1313.
S1313 is Using hardcoded IP addresses is security-sensitive and unimplemented for flex.

@loris-s-sonarsource loris-s-sonarsource changed the title Fix Rule ID Fix wrong Rule ID in ITS' expected rules Jun 15, 2023
@sonarsource-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit 3fb9c55 into master Jun 15, 2023
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource deleted the fix/rule-discrep branch June 15, 2023 10:05
@loris-s-sonarsource loris-s-sonarsource mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victor-diez-sonarsource victor-diez-sonarsource victor-diez-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loris-s-sonarsource @victor-diez-sonarsource @yassin-kammoun-sonarsource