SQ Plugin: Remove old runtime version checks #9560
Conversation
|
|
mary-georgiou-sonarsource
changed the title
mary-georgiou-sonarsource
left a comment
mary-georgiou-sonarsource
left a comment
There was a problem hiding this comment.
I left a comment about a test that seems to still use version < 9.9.
Please also recheck again because I see there are more occurrences of Version.create( for versions < 9.9. For Example in CSharpPluginTest.getExtensions
| assertThat(getSecurityStandards(Version.create(9, 4), PCI_DSS_RULE_KEY)).isEmpty(); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
What about this test?
Seems to be testing version 9.5.
There was a problem hiding this comment.
The version number passed here is not used in our Java codebase, it's just passed to the Plugin API. So there's not much we can do about it. I removed the test for version 9.4, because the minimum API version is 9.9, but this test should still work. I could change the version number to 9.9, but it wouldn't matter; at least it shows from which version this feature is available.
The same is true for other occurrences I didn't remove: the runtime versions are passed to the API, and you can only see them in the code from the decompiled .class files. We cannot remove them.
2 participants
Fixes #7798