Fix S1854 FP: Throw should visit finally #9530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastien-marichal
force-pushed
the
sma/lva-throw-finally
branch
from
b39bcb2 to
0efe47a
Compare
sebastien-marichal
force-pushed
the
sma/lva-throw-finally
branch
from
0efe47a to
071ba89
Compare
mary-georgiou-sonarsource
requested changes
Jul 18, 2024
Contributor
mary-georgiou-sonarsource
left a comment
mary-georgiou-sonarsource
left a comment
There was a problem hiding this comment.
Some refactoring
...ts/SonarAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.TryCatchFinally.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/RoslynLiveVariableAnalysis.cs
Outdated
Show resolved
Hide resolved
mary-georgiou-sonarsource
requested changes
Jul 19, 2024
Contributor
mary-georgiou-sonarsource
left a comment
mary-georgiou-sonarsource
left a comment
There was a problem hiding this comment.
As discussed I'm not sure why you get the first or default catch or throw.
Please take a look.
sebastien-marichal
force-pushed
the
sma/lva-throw-finally
branch
from
5364a23 to
69456ec
Compare
| { | ||
| AddBranch(block, catchBlock); | ||
| } | ||
| if (reachableCatchAndFinallyBlocks.Any() && reachableCatchAndFinallyBlocks.First() is { EnclosingRegion.Kind: ControlFlowRegionKind.Finally } finallyBlock) |
Contributor
There was a problem hiding this comment.
Suggested change
| if (reachableCatchAndFinallyBlocks.Any() && reachableCatchAndFinallyBlocks.First() is { EnclosingRegion.Kind: ControlFlowRegionKind.Finally } finallyBlock) | |
| if (reachableCatchAndFinallyBlocks.FirstOrDefault() is { EnclosingRegion.Kind: ControlFlowRegionKind.Finally } finallyBlock) |
|
|
| public void Using_Nested_Block_LiveInUntilTheEnd() | ||
| { | ||
| var code = """ | ||
| const string code = """ |
Contributor
There was a problem hiding this comment.
cons string has no performance benefit over var:
https://stackoverflow.com/a/49224799
This creates unnecessary visual noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9466
Depends on #9528