Fix S3963 FP: Static constructor with conditional and no static filed initialization#9512
Merged
sebastien-marichal merged 3 commits intomasterfrom Jul 11, 2024
Merged
Fix S3963 FP: Static constructor with conditional and no static filed initialization#9512sebastien-marichal merged 3 commits intomasterfrom
sebastien-marichal merged 3 commits intomasterfrom
Conversation
sebastien-marichal
force-pushed
the
sma/s3963-fp
branch
from
86818a2 to
c8b617e
Compare
mary-georgiou-sonarsource
approved these changes
Jul 11, 2024
Contributor
mary-georgiou-sonarsource
left a comment
mary-georgiou-sonarsource
left a comment
There was a problem hiding this comment.
LGTM - mino polishing - ignore if you wish as it does not worth blocking the whole PR for this.
| .Count(); | ||
| var hasIfOrSwitch = Array.Exists(bodyDescendantNodes, x => x.IsAnyKind(SyntaxKind.IfStatement, SyntaxKind.SwitchStatement)); | ||
| if ((hasIfOrSwitch && assignedFieldCount <= 1) | ||
| if ((hasIfOrSwitch && assignedFieldCount == 1) |
Contributor
There was a problem hiding this comment.
one line :)
sebastien-marichal
force-pushed
the
sma/s3963-fp
branch
from
c6dcd53 to
789f38c
Compare
|
|
Contributor
Author
|
Peach validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6343