Skip to content

Improve S3247: Rule should recommend pattern matching for new C# instead of as #9490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mary-georgiou-sonarsource merged 2 commits into from
Jul 1, 2024
Merged

Improve S3247: Rule should recommend pattern matching for new C# instead of as #9490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
209f359
Improve S3247: Rule should recommend pattern matching for new C# inst…
sebastien-marichal Jul 1, 2024
453cfe1
Update .NET ITs results
sebastien-marichal Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion analyzers/its/expected/Ember-MM/S3247-Ember.Plugins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Issues": [
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Ember-MM/Ember.Plugins/PluginManager.cs#L196",
"Location": "Line 196 Position 25-53"
}
Expand Down
36 changes: 18 additions & 18 deletions analyzers/its/expected/Nancy/S3247-Nancy-net452.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,109 +2,109 @@
"Issues": [
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/DynamicDictionaryValue.cs#L498",
"Location": "Line 498 Position 17-43"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/DynamicDictionaryValue.cs#L541",
"Location": "Line 541 Position 17-47"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/DynamicDictionaryValue.cs#L583",
"Location": "Line 583 Position 17-47"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L187",
"Location": "Line 187 Position 17-36"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L191",
"Location": "Line 191 Position 22-44"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L195",
"Location": "Line 195 Position 22-41"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L257",
"Location": "Line 257 Position 17-36"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L261",
"Location": "Line 261 Position 22-44"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L283",
"Location": "Line 283 Position 17-36"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L288",
"Location": "Line 288 Position 22-44"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L309",
"Location": "Line 309 Position 22-44"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L329",
"Location": "Line 329 Position 22-44"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Json/Converters/TimeSpanConverter.cs#L73",
"Location": "Line 73 Position 17-29"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Json/Converters/TimeSpanConverter.cs#L78",
"Location": "Line 78 Position 17-30"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Json/Simple/NancySerializationStrategy.cs#L188",
"Location": "Line 188 Position 17-34"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Json/Simple/NancySerializationStrategy.cs#L193",
"Location": "Line 193 Position 17-40"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Responses/Negotiation/DefaultResponseNegotiator.cs#L83",
"Location": "Line 83 Position 17-40"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/ViewEngines/SuperSimpleViewEngine/SuperSimpleViewEngine.cs#L182",
"Location": "Line 182 Position 17-48"
}
Expand Down
36 changes: 18 additions & 18 deletions analyzers/its/expected/Nancy/S3247-Nancy-netstandard2.0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,109 +2,109 @@
"Issues": [
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/DynamicDictionaryValue.cs#L498",
"Location": "Line 498 Position 17-43"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/DynamicDictionaryValue.cs#L541",
"Location": "Line 541 Position 17-47"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/DynamicDictionaryValue.cs#L583",
"Location": "Line 583 Position 17-47"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L187",
"Location": "Line 187 Position 17-36"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L191",
"Location": "Line 191 Position 22-44"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L195",
"Location": "Line 195 Position 22-41"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L257",
"Location": "Line 257 Position 17-36"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L261",
"Location": "Line 261 Position 22-44"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L283",
"Location": "Line 283 Position 17-36"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L288",
"Location": "Line 288 Position 22-44"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L309",
"Location": "Line 309 Position 22-44"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Helpers/ReflectionUtils.cs#L329",
"Location": "Line 329 Position 22-44"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Json/Converters/TimeSpanConverter.cs#L73",
"Location": "Line 73 Position 17-29"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Json/Converters/TimeSpanConverter.cs#L78",
"Location": "Line 78 Position 17-30"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Json/Simple/NancySerializationStrategy.cs#L188",
"Location": "Line 188 Position 17-34"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Json/Simple/NancySerializationStrategy.cs#L193",
"Location": "Line 193 Position 17-40"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/Responses/Negotiation/DefaultResponseNegotiator.cs#L83",
"Location": "Line 83 Position 17-40"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy/ViewEngines/SuperSimpleViewEngine/SuperSimpleViewEngine.cs#L182",
"Location": "Line 182 Position 17-48"
}
Expand Down
2 changes: 1 addition & 1 deletion analyzers/its/expected/Nancy/S3247-Nancy.Validation.DataAnnotations-net452.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Issues": [
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy.Validation.DataAnnotations/RangeValidatorAdapter.cs#L61",
"Location": "Line 61 Position 16-31"
}
Expand Down
6 changes: 3 additions & 3 deletions analyzers/its/expected/Nancy/S3247-Nancy.ViewEngines.Razor-net452.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@
"Issues": [
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy.ViewEngines.Razor/NancyRazorViewBase.cs#L249",
"Location": "Line 249 Position 17-49"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy.ViewEngines.Razor/NancyRazorViewBase.cs#L254",
"Location": "Line 254 Position 17-60"
},
{
"Id": "S3247",
"Message": "Replace this type-check-and-cast sequence with an \u0027as\u0027 and a null check.",
"Message": "Replace this type-check-and-cast sequence to use pattern matching.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/Nancy/src/Nancy.ViewEngines.Razor/NancyRazorViewBase.cs#L270",
"Location": "Line 270 Position 17-30"
}
Expand Down
Loading