Fix S2743 FN: Static fields of nested class inside generic class #9405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-mikula-sonarsource
force-pushed
the
Pavel/S2743-FN
branch
from
e5229aa to
7819433
Compare
| .Any(x => typeParameterNames.Contains(x.Identifier.Value) && context.SemanticModel.GetSymbolInfo(x).Symbol is { Kind: SymbolKind.TypeParameter }); | ||
|
|
||
| private static bool BaseTypeHasGenericTypeArgument(TypeDeclarationSyntax typeDeclaration, string[] typeParameterNames) => | ||
| typeDeclaration.BaseList is not null && typeDeclaration.BaseList.Types.Any(x => x.Type is GenericNameSyntax genericType && HasGenericTypeArgument(genericType, typeParameterNames)); |
Contributor
There was a problem hiding this comment.
Suggested change
| typeDeclaration.BaseList is not null && typeDeclaration.BaseList.Types.Any(x => x.Type is GenericNameSyntax genericType && HasGenericTypeArgument(genericType, typeParameterNames)); | |
| typeDeclaration.BaseList is {} baselist && baseList.Types.Any(x => x.Type is GenericNameSyntax genericType && HasGenericTypeArgument(genericType, typeParameterNames)); |
I like this more - up to you.
mary-georgiou-sonarsource
approved these changes
Jun 5, 2024
Contributor
mary-georgiou-sonarsource
left a comment
mary-georgiou-sonarsource
left a comment
There was a problem hiding this comment.
LGTM - I'm not merging as there are 2 PRs on the same rule and might be conflicting.
pavel-mikula-sonarsource
force-pushed
the
Pavel/S2743-FN
branch
from
7819433 to
1fdf227
Compare
pavel-mikula-sonarsource
force-pushed
the
Pavel/S2743-FN
branch
from
1fdf227 to
3ff63ce
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4081