Fix S3220 FP: Rule does not take into account generics#9389
Merged
mary-georgiou-sonarsource merged 3 commits intomasterfrom Jun 5, 2024
Merged
Fix S3220 FP: Rule does not take into account generics#9389mary-georgiou-sonarsource merged 3 commits intomasterfrom
mary-georgiou-sonarsource merged 3 commits intomasterfrom
Conversation
zsolt-kolbay-sonarsource
approved these changes
Jun 5, 2024
| { | ||
| Get<string>("text"); // Noncompliant FP | ||
| Get<string>("text"); // Compliant | ||
| GetBothHaveGenerics<string>(1); // Compliant, when both methods are generic it seems to resolving correctly to the T GetBothHaveGenerics<T>(int anInt). |
Contributor
There was a problem hiding this comment.
Add a test case where one of the generic methods has an object parameter:
T Generics<T>(params int[] ints) => default;
T Generics<T>(object anInt) => default;
...
Generics<string>(1); // Noncompliant| { | ||
| Get<string>("text"); // Noncompliant FP | ||
| Get<string>("text"); // Compliant | ||
| GetBothHaveGenerics<string>(1); // Compliant, when both methods are generic it seems to resolving correctly to the T GetBothHaveGenerics<T>(int anInt). |
Contributor
There was a problem hiding this comment.
Suggested change
| GetBothHaveGenerics<string>(1); // Compliant, when both methods are generic it seems to resolving correctly to the T GetBothHaveGenerics<T>(int anInt). | |
| GetBothHaveGenerics<string>(1); // Compliant, when both methods are generic, it seems to resolve correctly to the T GetBothHaveGenerics<T>(int anInt). |
mary-georgiou-sonarsource
force-pushed
the
mary/FP-S3220-params
branch
from
ab38e6b to
2bb8c77
Compare
mary-georgiou-sonarsource
changed the title
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8522