Skip to content

Fix S6964 FP: Add more attributes to the exclusions #9355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mary-georgiou-sonarsource merged 4 commits into from
May 30, 2024
Merged

Fix S6964 FP: Add more attributes to the exclusions #9355

mary-georgiou-sonarsource merged 4 commits into from
May 30, 2024

Conversation

@mary-georgiou-sonarsource
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource commented May 29, 2024 •
edited
Loading

Fixes #9337

With this PR I'm excluding properties annotated with:

  • JsonProperty(Required = Required.Always)
  • JsonProperty(Required = Required.AllowNull)
  • Newtonsoft.Json.JsonIgnore
  • Newtonsoft.Json.JsonRequired
  • System.Text.Json.Serialization.JsonRequired
  • System.Text.Json.Serialization.JsonIgnore
  • Range

martin-strecker-sonarsource
martin-strecker-sonarsource reviewed May 29, 2024
View reviewed changes
zsolt-kolbay-sonarsource
zsolt-kolbay-sonarsource approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title Fix S6964 FP: Don't raise when property is annotated with JSonProperty(Require = Always) or Range attribute Fix S6964 FP: Exclude properties for certain Json.NET attributes and more System.Text.Json.Serialization attributes May 30, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title Fix S6964 FP: Exclude properties for certain Json.NET attributes and more System.Text.Json.Serialization attributes Fix S6964 FP: Add more attributes to the exclusions May 30, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

zsolt-kolbay-sonarsource
zsolt-kolbay-sonarsource approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mary-georgiou-sonarsource mary-georgiou-sonarsource merged commit fb392af into master May 30, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource deleted the mary/S6964-moreexclusions branch May 30, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource left review comments

+1 more reviewer

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix S6964 FP: Add more attributes to the exclusions

3 participants

@mary-georgiou-sonarsource @martin-strecker-sonarsource @zsolt-kolbay-sonarsource