Fix S6966 FPs/FNs: FPs/FNs after peach validation

[martin-strecker-sonarsource]

S6966 - Awaitable method should be used

See #9179 (comment)

• Mongo DB: 3868cc1 FP. --> Documented but not fixed.
• MemoryStream.Flush: Not fixed. Flush and FlushAsync are both "No ops" (see Remark section for both). So Flush is wrong to begin with and FlushAsync is equally wrong. Other Async methods delegate to their sync counterpart and may be worth excluding (WriteAsync, ReadAsync). We can not exclude MemoryStream altogether, because CopyToAsync is a TP (calls WriteAsync of the destination stream). --> No action needed
• Endless recursion (The speculative resolved method symbol is the enclosing method). --> Fixed and tested d92f3fc

[mary-georgiou-sonarsource]

Some suggestions and I think we miss a UT.

[mary-georgiou-sonarsource]

Is is possible to add a test that fails if this line is not changed to add parentheses around the replacement?

[martin-strecker-sonarsource]

No. This is not possible. This is the funny part with SyntaxTree manipulations: You can end up with a syntax tree that is not expressible in code (If you take the transformed syntax tree, convert it to code, and convert it back to a tree, the new tree looks different). The parentheses are not needed in the tree because the tree looks like parentheses are present. The parentheses will be needed for the code fix though.
With the parentheses, debugging is a bit better because the text representation of the syntax tree is better.
I can remove all the trivia and parentheses handling because, for the speculative binding, they are not needed.

[mary-georgiou-sonarsource]

Maybe add a quick comment there to capture this?
On why there are parentheses.

[mary-georgiou-sonarsource]

I'll merge this to make it to the next release. Let's add a comment in one of the next PRs.
I'll keep a task on my calendar to not forget.

[mary-georgiou-sonarsource]

LGTM - there's couple more suggestions.
There's also a code smell for an unused parameter stayed after refactoring.

[sonarqubecloud]

Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[sonarqubecloud]

Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud