Skip to content

New rule S6962 for C#: You should pool HTTP connections with HttpClientFactory #9135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mary-georgiou-sonarsource merged 8 commits into from
Apr 24, 2024
Merged

New rule S6962 for C#: You should pool HTTP connections with HttpClientFactory #9135

mary-georgiou-sonarsource merged 8 commits into from
Apr 24, 2024

Conversation

@mary-georgiou-sonarsource
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource commented Apr 18, 2024

Fixes #9091

@mary-georgiou-sonarsource mary-georgiou-sonarsource marked this pull request as draft April 18, 2024 12:16
@mary-georgiou-sonarsource mary-georgiou-sonarsource force-pushed the mary/S6962 branch 5 times, most recently from 25a3cd2 to abd6ab6 Compare April 23, 2024 12:14
@mary-georgiou-sonarsource mary-georgiou-sonarsource marked this pull request as ready for review April 23, 2024 12:15
mary-georgiou-sonarsource
mary-georgiou-sonarsource commented Apr 23, 2024
View reviewed changes
gregory-paidis-sonarsource
gregory-paidis-sonarsource requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@gregory-paidis-sonarsource gregory-paidis-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
My comments are mostly about readability, the logic and tests look very good.

analyzers/src/SonarAnalyzer.CSharp/ReuseClientBase.cs
|| node.Parent.IsKind(SyntaxKind.ArrowExpressionClause));

private static bool IsInConditionalCode(SyntaxNode node) =>
node.Ancestors().Any(x => x.IsAnyKind(SyntaxKind.IfStatement,
Copy link
Contributor

@gregory-paidis-sonarsource gregory-paidis-sonarsource Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are doing this .Ancestors().Any(x => x.IsAnyKind(...) check 4-5 times, please extract it in CSharpSyntaxHelper:

public static bool HasAncestorOfKind(this SyntaxNode syntaxNode, params SyntaxKind[] syntaxKinds) =>
  syntaxNode.Ancestors().Any(ancestor => ancestor.IsAnyKind(syntaxKinds));

Copy link
Contributor

@martin-strecker-sonarsource martin-strecker-sonarsource Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also

sonar-dotnet/analyzers/src/SonarAnalyzer.CSharp/Common/Walkers/MutedSyntaxWalker.cs

Lines 127 to 128 in f64e085

private static bool HasAncestor(SyntaxNode node, SyntaxKind kind) =>
node.FirstAncestorOrSelf<SyntaxNode>(x => x.IsKind(kind)) != null;

Copy link
Contributor Author

@mary-georgiou-sonarsource mary-georgiou-sonarsource Apr 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do it in a separate cleanup PR to replace it everywhere in sonar-dotnet if that's ok.
I saw there are quite some occurrences.

EDIT: I just saw Martin's comment. For some reason, it was not loaded earlier. I'm checking that option now.

gregory-paidis-sonarsource
gregory-paidis-sonarsource approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@gregory-paidis-sonarsource gregory-paidis-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left only one comment to in-line a method, please take a look.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mary-georgiou-sonarsource mary-georgiou-sonarsource merged commit 682542b into master Apr 24, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource deleted the mary/S6962 branch April 24, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource left review comments

@gregory-paidis-sonarsource gregory-paidis-sonarsource gregory-paidis-sonarsource approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New rule S6962 for C#: You should pool HTTP connections with HttpClientFactory

3 participants

@mary-georgiou-sonarsource @martin-strecker-sonarsource @gregory-paidis-sonarsource