New rule T0001: Use FileScoped namespaces #9050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-mikula-sonarsource
force-pushed
the
Pavel/T0001
branch
from
d390643 to
273f431
Compare
sebastien-marichal
requested changes
Apr 9, 2024
Contributor
sebastien-marichal
left a comment
sebastien-marichal
left a comment
There was a problem hiding this comment.
I left a small suggestion
|
|
||
| [TestMethod] | ||
| public void FileScopeNamespace_Compliant() => | ||
| builder.AddPaths("FileScopeNamespace.Compliant.cs").Verify(); |
Contributor
There was a problem hiding this comment.
For this kind of test, I believe it is better to be explicit that there are no issues at all:
Suggested change
| builder.AddPaths("FileScopeNamespace.Compliant.cs").Verify(); | |
| builder.AddPaths("FileScopeNamespace.Compliant.cs").VerifyNoIssueReported(); |
In my opinion, Verify should fail if there is no issue reported.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9035
This is based on #9048 and #9049. These commits do not need review:Simplify registration extensionsCreate SonarAnalyzer.CSharp.Styling projectUpdate locks