Skip to content

Fix S2094 FP: Marker interfaces for record types #8938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zsolt-kolbay-sonarsource merged 3 commits into from
Mar 20, 2024
Merged

Fix S2094 FP: Marker interfaces for record types #8938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcdf32a
Fix S2094 FP: Marker interfaces for record types
zsolt-kolbay-sonarsource Mar 18, 2024
911b723
Update ITs
zsolt-kolbay-sonarsource Mar 18, 2024
a7b3df3
Fxi typo
zsolt-kolbay-sonarsource Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions analyzers/its/expected/CSharpLatest/S2094-CSharpLatest-net8.0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,6 @@
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/CSharpLatest/CSharpLatest/CSharp9Features/Records.cs#L109",
"Location": "Line 109 Position 15-16"
},
{
"Id": "S2094",
"Message": "Remove this empty record, write its code or make it an \u0022interface\u0022.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/CSharpLatest/CSharpLatest/CSharp9Features/Records.cs#L130",
"Location": "Line 130 Position 15-16"
},
{
"Id": "S2094",
"Message": "Remove this empty record, write its code or make it an \u0022interface\u0022.",
Expand Down
2 changes: 1 addition & 1 deletion analyzers/src/SonarAnalyzer.CSharp/Rules/ClassShouldNotBeEmpty.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ protected override bool IsEmptyAndNotPartial(SyntaxNode node) =>
&& (node is ClassDeclarationSyntax || IsParameterlessRecord(node));

protected override BaseTypeDeclarationSyntax GetIfHasDeclaredBaseClassOrInterface(SyntaxNode node) =>
node is ClassDeclarationSyntax { BaseList: not null } declaration
node is TypeDeclarationSyntax { BaseList: not null } declaration
? declaration
: null;

Expand Down
2 changes: 1 addition & 1 deletion analyzers/src/SonarAnalyzer.Common/Rules/ClassShouldNotBeEmptyBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,5 @@ private static bool ShouldIgnoreType(TDeclarationSyntax node, SemanticModel mode
model.GetDeclaredSymbol(node) is INamedTypeSymbol classSymbol
&& (classSymbol.BaseType is { IsAbstract: true }
|| classSymbol.DerivesFromAny(BaseClassesToIgnore)
|| classSymbol.Interfaces.Any());
|| classSymbol.Interfaces.Any(x => !x.Is(KnownType.System_IEquatable_T))); // every record type implicitly implements System.IEquatable<T>
}
8 changes: 8 additions & 0 deletions analyzers/tests/SonarAnalyzer.Test/TestCases/ClassShouldNotBeEmpty.CSharp9.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,11 @@ namespace Ignore
partial record EmptyPartialRecord(); // Compliant - partial classes are ignored, so partial record classes are ignored as well
}

// https://github.com/SonarSource/sonar-dotnet/issues/7709
namespace Repro_7709
{
interface IMarker { }
record ImplementsMarker : IMarker { }
record ImplementsEmptyRecordAndMarker : Noncompliant.EmptyRecord, IMarker { }
}