Fix S2701 FP: avoid raising for xUnit Assert.True()#8823
Merged
cristian-ambrosini-sonarsource merged 1 commit intomasterfrom Feb 28, 2024
Merged
Fix S2701 FP: avoid raising for xUnit Assert.True()#8823cristian-ambrosini-sonarsource merged 1 commit intomasterfrom
cristian-ambrosini-sonarsource merged 1 commit intomasterfrom
Conversation
|
|
github-actions
bot
assigned
sebastien-marichal and unassigned
cristian-ambrosini-sonarsource
github-actions
bot
assigned
cristian-ambrosini-sonarsource and unassigned
sebastien-marichal
cristian-ambrosini-sonarsource
added
Area: C#
False Positive
Contributor
Author
|
Peach validation: Lost 51 issues, all TN |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S2701 is not raising for
Assert.Truein xUnit becauseAssert.Failwas introduced in 2020 version2.4.2andAssert.True(false, message)was a way to simulate it. Now that we are promoting this rule to SonarWay we want to play it safe and avoid raising also forAssert.Falsefor the same reasonAssert.False(true, message).