Skip to content

Fix S2259 FN: FlowCaptures in Field/PropertyReference.Instance #8335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mary-georgiou-sonarsource merged 1 commit into from
Nov 8, 2023
Merged

Fix S2259 FN: FlowCaptures in Field/PropertyReference.Instance #8335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/ExceptionCandidate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private ExceptionState FromOperation(IArrayElementReferenceOperationWrapper refe
: new ExceptionState(typeCatalog.SystemIndexOutOfRangeException);

private ExceptionState FromOperation(ProgramState state, IMemberReferenceOperationWrapper reference) =>
reference.IsStaticOrThis()
reference.IsStaticOrThis(state)
|| state[reference.Instance]?.HasConstraint(ObjectConstraint.NotNull) is true
|| reference.IsOnReaderWriterLockOrSlim() // Needed by S2222
? null
Expand Down
8 changes: 4 additions & 4 deletions ...zers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/Extensions/IOperationExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ internal static ISymbol TrackedSymbol(this IOperation operation, ProgramState st
{
OperationKindEx.FlowCaptureReference when state.ResolveCapture(operation) is var resolved && resolved != operation => resolved.TrackedSymbol(state),
OperationKindEx.Conversion when operation.ToConversion() is var conversion && (!conversion.IsTryCast || conversion.IsUpcast()) => TrackedSymbol(operation.ToConversion().Operand, state),
OperationKindEx.FieldReference when operation.ToFieldReference() is var fieldReference && IsStaticOrThis(fieldReference) && !fieldReference.Type.IsEnum() => fieldReference.Field,
OperationKindEx.FieldReference when operation.ToFieldReference() is var fieldReference && IsStaticOrThis(fieldReference, state) && !fieldReference.Type.IsEnum() => fieldReference.Field,
OperationKindEx.LocalReference => operation.ToLocalReference().Local,
OperationKindEx.ParameterReference => operation.ToParameterReference().Parameter,
OperationKindEx.Argument => operation.ToArgument().Value.TrackedSymbol(state),
OperationKindEx.DeclarationExpression => IDeclarationExpressionOperationWrapper.FromOperation(operation).Expression.TrackedSymbol(state),
OperationKindEx.PropertyReference when operation.ToPropertyReference() is { Property: { IsVirtual: false } property } propertyReference
&& IsStaticOrThis(propertyReference)
&& IsStaticOrThis(propertyReference, state)
&& property.IsAutoProperty()
=> property,
_ => null
Expand Down Expand Up @@ -120,9 +120,9 @@ internal static IEventReferenceOperationWrapper ToEventReference(this IOperation
internal static IUnaryOperationWrapper ToUnary(this IOperation operation) =>
IUnaryOperationWrapper.FromOperation(operation);

public static bool IsStaticOrThis(this IMemberReferenceOperationWrapper reference) =>
public static bool IsStaticOrThis(this IMemberReferenceOperationWrapper reference, ProgramState state) =>
reference.Instance == null // static fields
|| reference.Instance.Kind == OperationKindEx.InstanceReference;
|| state.ResolveCaptureAndUnwrapConversion(reference.Instance).Kind == OperationKindEx.InstanceReference;

public static IOperation UnwrapConversion(this IOperation operation)
{
Expand Down
2 changes: 1 addition & 1 deletion ...narAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/NullPointerDereference.CSharp6.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ void ConditionalThisFieldAccess()
{
object o = null;
this._foo1 = o;
this?._foo1.ToString(); // Not supported, TrackedSymbol() does not resolve flow capture references
this?._foo1.ToString(); // Noncompliant
}

string TryCatch3()
Expand Down