Adding missing operation wrappers and syntax kinds to the shim layer#8271
Merged
Tim-Pohlmann merged 5 commits intomasterfrom Nov 2, 2023
Merged
Adding missing operation wrappers and syntax kinds to the shim layer#8271Tim-Pohlmann merged 5 commits intomasterfrom
Tim-Pohlmann merged 5 commits intomasterfrom
Conversation
martin-strecker-sonarsource
requested changes
Oct 27, 2023
analyzers/src/SonarAnalyzer.CFG/ShimLayer/OperationInterfaces.xml
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CFG/ShimLayer/OperationInterfaces.xml
Outdated
Show resolved
Hide resolved
martin-strecker-sonarsource
approved these changes
Oct 31, 2023
Contributor
martin-strecker-sonarsource
left a comment
martin-strecker-sonarsource
left a comment
There was a problem hiding this comment.
LGTM. But please anwser the questions and consider adding the suggestion.
analyzers/src/SonarAnalyzer.ShimLayer.CodeGeneration/OperationLightupGenerator.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Strecker <103252490+martin-strecker-sonarsource@users.noreply.github.com>
Tim-Pohlmann
force-pushed
the
Tim/UpdateShimLayer
branch
from
e7c3f22 to
6422efa
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.