check the kind fon't cast

SonarSource · Jul 20, 2023 · 2cd9d9c · 2cd9d9c
1 parent 0935a93
commit 2cd9d9c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/...zers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/Extensions/IOperationExtensions.cs b/...zers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/Extensions/IOperationExtensions.cs
@@ -61,9 +61,6 @@ static bool IsTryDownCast(IConversionOperationWrapper conversion) =>
     internal static IIsPatternOperationWrapper? AsIsPattern(this IOperation operation) =>
         operation.As(OperationKindEx.IsPattern, IIsPatternOperationWrapper.FromOperation);
 
-    internal static ILiteralOperationWrapper? AsLiteral(this IOperation operation) =>
-        operation.As(OperationKindEx.Literal, ILiteralOperationWrapper.FromOperation);
-
     internal static IMethodReferenceOperationWrapper? AsMethodReference(this IOperation operation) =>
         operation.As(OperationKindEx.MethodReference, IMethodReferenceOperationWrapper.FromOperation);
 

diff --git a/...lyzer.Common/SymbolicExecution/Roslyn/RuleChecks/HashesShouldHaveUnpredictableSaltBase.cs b/...lyzer.Common/SymbolicExecution/Roslyn/RuleChecks/HashesShouldHaveUnpredictableSaltBase.cs
@@ -76,8 +76,9 @@ private void ProcessObjectCreation(ProgramState state, IObjectCreationOperationW
     protected override ProgramState ProcessInvocation(ProgramState state, IInvocationOperationWrapper invocation)
     {
         state = base.ProcessInvocation(state, invocation);
-        return invocation.TargetMethod.Is(KnownType.System_Text_Encoding, nameof(Encoding.GetBytes)) && FindInvocationArgument(state, invocation.Arguments, KnownType.System_String)?.AsLiteral() is { }
-            ? state.SetOperationConstraint(invocation, ByteCollectionConstraint.CryptographicallyWeak)
-            : state;
+        return invocation.TargetMethod.Is(KnownType.System_Text_Encoding, nameof(Encoding.GetBytes))
+            && FindInvocationArgument(state, invocation.Arguments, KnownType.System_String)?.Kind == OperationKindEx.Literal
+                ? state.SetOperationConstraint(invocation, ByteCollectionConstraint.CryptographicallyWeak)
+                : state;
     }
 }
diff --git a/...yzer.Common/SymbolicExecution/Roslyn/RuleChecks/InitializationVectorShouldBeRandomBase.cs b/...yzer.Common/SymbolicExecution/Roslyn/RuleChecks/InitializationVectorShouldBeRandomBase.cs
@@ -92,6 +92,6 @@ private static bool IsCreateEncryptorMethod(IInvocationOperationWrapper invocati
         && invocation.TargetMethod.ContainingType.DerivesFrom(KnownType.System_Security_Cryptography_SymmetricAlgorithm);
 
     private static bool IsIVProperty(IPropertyReferenceOperationWrapper property, ISymbol propertyInstance) =>
-        property.Property.Name == "IV"
+        property.Property.Name == nameof(SymmetricAlgorithm.IV)
         && propertyInstance.GetSymbolType().DerivesFrom(KnownType.System_Security_Cryptography_SymmetricAlgorithm);
 }