S1694: Promote C# to SonarWay and remove protected constructor #3960
Conversation
pavel-mikula-sonarsource
force-pushed
the
Pavel/S1694
branch
from
849b06e to
cb03cd9
Compare
CristianAmbrosini
left a comment
CristianAmbrosini
left a comment
There was a problem hiding this comment.
Let's add a How to Fix it and Resources section
CristianAmbrosini
left a comment
CristianAmbrosini
left a comment
There was a problem hiding this comment.
Looks good! Left a few minor comments and 1 question
|
|
||
| * https://en.wikipedia.org/wiki/Multiple_inheritance[**Multiple Inheritance**]: Unlike classes, an interface doesn't count towards the single inheritance limit in C#. This means a class can implement multiple interfaces, which can be useful when you need to define behavior that can be shared across multiple classes. | ||
| * https://en.wikipedia.org/wiki/Loose_coupling#In_programming[**Loose Coupling**]: Interfaces provide a way to achieve loose coupling between classes. This is because an interface only specifies what methods a class must have, but not how they are implemented. This makes it easier to swap out implementations without changing the code that uses them. | ||
| * https://en.wikipedia.org/wiki/Polymorphism_(computer_science)[**Polymorphism**]: Interfaces allow you to use polymorphism, which means you can use an interface type to refer to any object that implements that interface. This can be useful when you want to write code that can work with any class that implements a certain interface, _without knowing what the actual class is_. |
There was a problem hiding this comment.
Isn't this the same for abstract classes? (referring to Polymorphism) Example
There was a problem hiding this comment.
Not any class, only classes that don't derive from anything, and as such can derive from the pure abstract class.
In your example, if Dog derived from the abstract class Pet, it could not derive from Animal.
| === Exceptions | ||
|
|
||
| === Noncompliant code example | ||
| `abstract` classes that contain non-abstract methods, in addition to `abstract` ones, cannot easily be converted to interfaces, and are not the subject of this rule: |
There was a problem hiding this comment.
Should we mention fields as well?
| abstract void Move(); | ||
| abstract void Feed(); | ||
| } | ||
| private bool switchLamp = false; |
There was a problem hiding this comment.
Also this field makes it compliant
There was a problem hiding this comment.
Mentioned in a dedicated paragraph on field.
zsolt-kolbay-sonarsource
left a comment
zsolt-kolbay-sonarsource
left a comment
There was a problem hiding this comment.
A few questions/polishing.
|
|
4 participants
Related to SonarSource/sonar-dotnet#8795
Review
A dedicated reviewer checked the rule description successfully for: