Skip to content

JS-261 Update easy deps #4825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zglicz merged 3 commits into from
Sep 19, 2024
Merged

JS-261 Update easy deps #4825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aaa5d91
Update deps
zglicz Sep 18, 2024
84a676c
@eslint-community/regesxpp
zglicz Sep 18, 2024
5c032e3
update ruling
zglicz Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion its/ruling/src/test/expected/jsts/ant-design/javascript-S6790.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"ant-design:components/upload/__tests__/upload.test.js": [
37,
Copy link
Contributor Author

@zglicz zglicz Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stopped showing up due to an update in eslint-react-plugin in v7.36 - commit jsx-eslint/eslint-plugin-react#3807

43
]
}
26 changes: 6 additions & 20 deletions its/ruling/src/test/expected/jsts/console/typescript-S6790.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,51 +6,38 @@
83
],
"console:src/components/Help/Alert.tsx": [
28,
38
],
"console:src/components/Help/Help.tsx": [
28,
36
],
"console:src/components/PopupWrapper/PopupWrapper.tsx": [
47,
56
Comment on lines -9 to -18
Copy link
Contributor Author

@zglicz zglicz Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same explanation for this file as above

47
],
"console:src/components/ScrollBox/ScrollBox.tsx": [
35,
49,
53
],
"console:src/components/Tether/Tether.tsx": [
42,
42,
43,
74
],
"console:src/components/ToggleButton/ToggleButton.tsx": [
59,
83
59
],
"console:src/views/ProjectRootView/AddModelPopup.tsx": [
139,
163
139
],
"console:src/views/ProjectRootView/EditModelPopup.tsx": [
145,
186
145
],
"console:src/views/ProjectSettingsView/ProjectSettingsView.tsx": [
82,
216
82
],
"console:src/views/RootView/RootView.tsx": [
26,
50
],
"console:src/views/models/DatabrowserView/Cell.tsx": [
116,
127
116
],
"console:src/views/models/DatabrowserView/Cell/DefaultCell.tsx": [
11
Expand All @@ -65,7 +52,6 @@
11
],
"console:src/views/models/DatabrowserView/Cell/StringCell.tsx": [
37,
49,
71
]
Expand Down
3 changes: 3 additions & 0 deletions its/ruling/src/test/expected/jsts/desktop/typescript-S6819.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
{
"desktop:app/src/ui/app-menu/app-menu-bar-button.tsx": [
190
],
Comment on lines +2 to +4
Copy link
Contributor Author

@zglicz zglicz Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a false positive stemming from using React components and us not understanding it. This was first reported here - https://community.sonarsource.com/t/s6819-prefer-tag-over-role-is-misleading/107348/7 and we have a jira task to track these - https://github.com/SonarSource/SonarJS/issues/4647

I'm not sure why it just now starting showing up in the ruling, but I think it's fair.

"desktop:app/src/ui/changes/commit-message.tsx": [
753
],
Expand Down
6 changes: 6 additions & 0 deletions its/ruling/src/test/expected/jsts/moose/typescript-S1082.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
"moose:renderer/components/Cast/Cast.tsx": [
51
],
"moose:renderer/components/Downloads/Downloads.tsx": [
130
],
"moose:renderer/components/FilesList/FilesList.tsx": [
165
],
Comment on lines +5 to +10
Copy link
Contributor Author

@zglicz zglicz Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a true-positive, that wasn't triggering before
image

Comment on lines +9 to +10
Copy link
Contributor Author

@zglicz zglicz Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True-positive

image

"moose:renderer/components/Settings/Settings.tsx": [
60,
78
Expand Down
3 changes: 0 additions & 3 deletions its/ruling/src/test/expected/jsts/redux/javascript-S6790.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
{
"redux:examples/real-world/components/Explore.js": [
19,
26,
Comment on lines -3 to -4
Copy link
Contributor Author

@zglicz zglicz Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same explanation as above

44
],
"redux:examples/todos-with-undo/components/AddTodo.js": [
6,
18
]
}
Loading