JS-192 Build working esling-plugin-sonarjs package #4750

ilia-kebets-sonarsource · 2024-07-02T08:19:07Z

Fixes #

…of module

…gin-sonarjs now

ilia-kebets-sonarsource · 2024-07-08T12:53:37Z

its/eslint-plugin-sonarjs/test/integration/index.test.ts

I didn't manage to run it programmatically without using the linter API, but I believe that what we want to test is CLI usage.

ilia-kebets-sonarsource · 2024-07-08T12:54:18Z

package.json

@@ -29,7 +32,8 @@
    "_:plugin:prepare-bridge": "npm pack && node tools/check-distribution-filepath-length.js && npm run _:plugin:copy-bridge",
    "_:plugin-fetch-node": "node tools/fetch-node/scripts/wrapper.mjs",
    "_:plugin:pre-build": "npm run bridge:build && npm run _:plugin:prepare-bridge && npm run _:plugin-fetch-node",
-    "_:plugin:copy-bridge": "cpy sonarjs-1.0.0.tgz sonar-plugin/sonar-javascript-plugin/target/classes && cpy sonarjs-1.0.0.tgz sonar-plugin/standalone/target/classes"
+    "_:plugin:copy-bridge": "cpy sonarjs-1.0.0.tgz sonar-plugin/sonar-javascript-plugin/target/classes && cpy sonarjs-1.0.0.tgz sonar-plugin/standalone/target/classes",
+    "eslint-plugin:pack": "cpy lib packages/eslint-plugin-sonarjs && npm pack --workspaces && rm -rf packages/eslint-plugin-sonarjs/lib"


maybe I could move this to packages/eslint-plugin-sonarjs/package.json?

ilia-kebets-sonarsource · 2024-07-08T12:57:15Z

packages/jsts/src/linter/issues/decode.ts

all these changes is because I removed the debug log containing ruleId in https://github.com/SonarSource/SonarJS/pull/4750/files#diff-0bab53c07af551fd3f82e7fc7a78b69e6a3aa892e5a27c4de9617025d27ef4ac

ilia-kebets-sonarsource · 2024-07-08T13:28:31Z

packages/jsts/src/rules/S1541/rule.ts

We cannot load all of linter because of:

Cannot find module '@sonar/shared' from 'node_modules/eslint-plugin-sonarjs/lib/jsts/src/linter/config/linter-config.js' Require stack: node_modules/eslint-plugin-sonarjs/lib/jsts/src/linter/config/linter-config.js node_modules/eslint-plugin-sonarjs/lib/jsts/src/linter/config/index.js node_modules/eslint-plugin-sonarjs/lib/jsts/src/linter/index.js node_modules/eslint-plugin-sonarjs/lib/jsts/src/rules/S2699/rule.js node_modules/eslint-plugin-sonarjs/lib/jsts/src/rules/S2699/index.js node_modules/eslint-plugin-sonarjs/lib/eslint-plugin-sonarjs/src/index.js test/unit/index.test.ts

ilia-kebets-sonarsource · 2024-07-08T14:19:30Z

packages/eslint-plugin-sonarjs/src/index.ts

+rules['xml-parser-xxe'] = S2755;
+rules['xpath'] = S4817;
+
+//import { name, version } from '../package.json';


find some solution for this: the path is different in the transpiled code, so it fails when running the generated package.

ilia-kebets-sonarsource · 2024-07-08T14:25:09Z

tools/eslint-plugin-sonarjs/build-to-its.sh

+
+cd its/eslint-plugin-sonarjs
+
+rm -rf node_modules/eslint-plugin-sonarjs


maybe this is not necessary anymore

sonarqube-next · 2024-07-08T14:51:10Z

Quality Gate failed

Failed conditions
84 New issues
82.1% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

ilia-kebets-sonarsource · 2024-07-10T06:33:23Z

here were the issues I ran into for a few rules that I had decided to omit from the package:

TypeError: context.getFirstTokens is not a function
Occurred while linting /private/tmp/test-plugin/file.js:1
Rule: "sonarjs/jsx-no-constructed-context-values"
    at Object.isAnnotatedFunctionPropsDeclaration (/private/tmp/test-plugin/node_modules/eslint-plugin-sonarjs/node_modules/eslint-plugin-react/lib/util/annotations.js:22:26)
    at markAnnotatedFunctionArgumentsAsDeclared (/private/tmp/test-plugin/node_modules/eslint-plugin-sonarjs/node_modules/eslint-plugin-react/lib/util/propTypes.js:1030:41)
    at /private/tmp/test-plugin/node_modules/eslint-plugin-sonarjs/node_modules/eslint-plugin-react/lib/util/Components.js:277:9
    at Array.forEach (<anonymous>)
    at mergedHandler (/private/tmp/test-plugin/node_modules/eslint-plugin-sonarjs/node_modules/eslint-plugin-react/lib/util/Components.js:276:16)
    at ruleErrorHandler (/private/tmp/test-plugin/node_modules/eslint/lib/linter/linter.js:1113:48)
    at /private/tmp/test-plugin/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/private/tmp/test-plugin/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/private/tmp/test-plugin/node_modules/eslint/lib/linter/node-event-generator.js:297:26)



TypeError: Cannot read properties of undefined (reading 'some')
Occurred while linting /private/tmp/test-plugin/file.js:1
Rule: "sonarjs/no-inconsistent-returns"
    at checkFunctionForImplicitReturn (/private/tmp/test-plugin/node_modules/eslint-plugin-sonarjs/lib/jsts/src/rules/S3801/rule.js:64:95)
    at checkFunctionLikeDeclaration (/private/tmp/test-plugin/node_modules/eslint-plugin-sonarjs/lib/jsts/src/rules/S3801/rule.js:50:13)
    at checkOnFunctionExit (/private/tmp/test-plugin/node_modules/eslint-plugin-sonarjs/lib/jsts/src/rules/S3801/rule.js:43:47)
    at ruleErrorHandler (/private/tmp/test-plugin/node_modules/eslint/lib/linter/linter.js:1113:48)
    at /private/tmp/test-plugin/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/private/tmp/test-plugin/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/private/tmp/test-plugin/node_modules/eslint/lib/linter/node-event-generator.js:297:26)
    at NodeEventGenerator.applySelectors (/private/tmp/test-plugin/node_modules/eslint/lib/linter/node-event-generator.js:326:22)
    at NodeEventGenerator.leaveNode (/private/tmp/test-plugin/node_modules/eslint/lib/linter/node-event-generator.js:349:14)
    $

vdiez and others added 30 commits June 18, 2024 16:29

WIP

b5d1a45

wip

72a799b

WIP

f249dd0

wip

ee8bdfc

WIP

9fcb76b

wip

08b129d

all rules merged into SonarJS

af75dc9

fix tests

a128eed

fix tests

a988283

fix license headers

a01a84a

wip metadata

b9010f2

Metadata generation from RSPEC

fcd00b2

correct types for metadata

afcde3c

Wip

cb425b6

WIP - write up integration test

e513205

move runtime to rules

66bbe58

all rules with metadata

d637c06

fix build errors

5ee245e

consider suggestion has valid quickfixes

216a4cf

initialize meta to empty object

b7c55a0

fix sonar-runtime detection

03ab63f

fix sonar-context

eaad8d8

fix default options to allow falsy values

66dfc2f

fix secondary locations usage check

cd63462

copy dependency on toUnixPath()

11d5b9a

copy JSON files when compiling (needed for meta.json)

ace404c

hack dependency on childrenOf to point directly to its file, instead …

c9196c2

…of module

use dedicated index for eslint-plugin-sonarjs main

f44baa8

add maybe useful tsconfig

18ee9d2

hack: remove debug usage

a49645e

vdiez and others added 11 commits July 4, 2024 14:24

fix unit tests

85c9c60

fix unit tests

8376531

only enable a few rules

6c8133d

add required dependencies and remove rules that fail for weird reasons

c1d0856

fix tests

f1aab95

Merge branch 'merge-eslint-plugin' into release-esling-plugin-sonarjs

70a72b1

Merge branch 'merge-eslint-plugin' into release-esling-plugin-sonarjs

453d51d

cleanup and add readme

e99eaba

push next todos

8437c41

delete useless package.json, as we use the one in packages/eslint-plu…

99c56ee

…gin-sonarjs now

fix issue

1683ed3

ilia-kebets-sonarsource changed the title ~~JS-192 Release esling-plugin-sonarjs~~ JS-192 Build working esling-plugin-sonarjs package Jul 8, 2024

ilia-kebets-sonarsource marked this pull request as ready for review July 8, 2024 07:06

ilia-kebets-sonarsource added 3 commits July 8, 2024 12:51

write up integration test

c86d52e

implement script

0ad5a0f

write sync-versions script

07945fc

ilia-kebets-sonarsource commented Jul 8, 2024

View reviewed changes

reference scripts

ae71753

ilia-kebets-sonarsource commented Jul 8, 2024

View reviewed changes

fix scripts

9311441

ilia-kebets-sonarsource requested a review from vdiez July 8, 2024 13:41

hashicorp-vault-sonar-prod bot assigned vdiez Jul 8, 2024

ilia-kebets-sonarsource commented Jul 8, 2024

View reviewed changes

cleanup

62fe9d8

Base automatically changed from merge-eslint-plugin to master July 8, 2024 14:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JS-192 Build working esling-plugin-sonarjs package #4750

JS-192 Build working esling-plugin-sonarjs package #4750

ilia-kebets-sonarsource commented Jul 2, 2024

ilia-kebets-sonarsource Jul 8, 2024

ilia-kebets-sonarsource Jul 8, 2024

ilia-kebets-sonarsource Jul 8, 2024

ilia-kebets-sonarsource Jul 8, 2024

ilia-kebets-sonarsource Jul 8, 2024

ilia-kebets-sonarsource Jul 8, 2024

sonarqube-next bot commented Jul 8, 2024

ilia-kebets-sonarsource commented Jul 10, 2024


		cd its/eslint-plugin-sonarjs

		rm -rf node_modules/eslint-plugin-sonarjs

JS-192 Build working esling-plugin-sonarjs package #4750

Are you sure you want to change the base?

JS-192 Build working esling-plugin-sonarjs package #4750

Conversation

ilia-kebets-sonarsource commented Jul 2, 2024

ilia-kebets-sonarsource Jul 8, 2024

Choose a reason for hiding this comment

ilia-kebets-sonarsource Jul 8, 2024

Choose a reason for hiding this comment

ilia-kebets-sonarsource Jul 8, 2024

Choose a reason for hiding this comment

ilia-kebets-sonarsource Jul 8, 2024

Choose a reason for hiding this comment

ilia-kebets-sonarsource Jul 8, 2024

Choose a reason for hiding this comment

ilia-kebets-sonarsource Jul 8, 2024

Choose a reason for hiding this comment

sonarqube-next bot commented Jul 8, 2024

Quality Gate failed

ilia-kebets-sonarsource commented Jul 10, 2024