Chat with me button on profile #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michielbdejong
changed the title
|
Depends on SolidOS/chat-pane#45 |
|
Idea for a follow-up improvement: The current implementation requires the logged in user to grant the visited pod Write+Control access to their own pod, which is not ideal. To resolve this, we should have a list of deployed chat apps that can receive a 'create' action, and see if the user has any of those as a trusted app. If they don't, the button can still offer to send the other user an invite, without creating the chat room (leaving that up to the other person) |
|
|
SharonStrats
approved these changes
Aug 21, 2020
timbl
requested changes
Aug 21, 2020
angelo-v
reviewed
Aug 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.