Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cached server to XDG-compliant location #28

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

milhnl
Copy link
Contributor

@milhnl milhnl commented Sep 27, 2024

Hey, I'm working on integrating this project into my workflow. This seems like a useful first step, as I like to keep my home directory clean. Please take a look at the "roslyn-language-server.github.com" url included in the commit. It's meant to be a project url. I use my own domain for this most of the time, but I did not see a website on your GitHub profile, so this is just a suggestion. I think it is only used in url form on macOS.

@SofusA
Copy link
Owner

SofusA commented Sep 28, 2024

Thanks for working on this. This is great!

In start_roslyn() a log directory is located relative to the home directory.
I think we should use the project directory here as well and remove the dependency to home

@SofusA
Copy link
Owner

SofusA commented Sep 28, 2024

It would make sense to find the project directory in start_roslyn() and add project directory as an argument to ensure_roslyn_is_installed().

Also refactor path handling a bit to be immutable.
@milhnl
Copy link
Contributor Author

milhnl commented Sep 29, 2024

Hi, thanks for the suggestions! I completely missed the log files. I couldn't resist make the path handling immutable, so the commit is a bit bigger than necessary. If you want me to split it, that's possible, but I thought you wouldn't care.

@SofusA
Copy link
Owner

SofusA commented Sep 29, 2024

This is nice 😃

I really appreciate your work.

@SofusA SofusA merged commit f07e0a5 into SofusA:main Sep 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants