Fix Compile Warnings #5963
Merged
Fix Compile Warnings #5963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least as much as possible without significantly altering parts of the application
json::parse was being called on the object, rather than statically like it should be. Also, the value was not being captured.
By having the definition in the header, it causes issues when other files define ICON_SIZE. By renaming it to MM_ICON_SIZE, this lessens the issue. It would probably be ideal to have the definitions in the respective .cpp that use them, but it would make it less convenient to update the values if needed in the future.
|
With warnings you can at least to see build progress))) |
Still TODO: check double for loop in Print.cpp
SoftFever
approved these changes
Jul 29, 2024
SoftFever
added a commit
that referenced
this pull request
Jul 29, 2024
This reverts commit b83e16d.
SoftFever
added a commit
that referenced
this pull request
Aug 11, 2024
This reverts commit b83e16d. Found regressions like auto orientation didn't work anymore after this change, revert it
|
I wanted to give a heads-up that I reverted this PR due to some issues I found. Issues I found in case you're curious:
|
|
No problem! I wasn't entirely done with development on this anyway, so I'll continue to work on it when I can 😁 |
|
Probably let's split the task - for instance I guess it's harmless to resolve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR clears up almost all of the compile warnings generated when building the slicer on Windows. There are still a few signed/unsigned issues, but fixing those would require larger codebase changes. I tried to keep these changes pretty simple.
Tests
Tested on Windows 11