Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Snapmaker profiles #5763

Merged
merged 9 commits into from
Jun 21, 2024
Merged

Fix Snapmaker profiles #5763

merged 9 commits into from
Jun 21, 2024

Conversation

macdylan
Copy link
Contributor

#b7b3418 cause an error:

[error]	2024-06-18 23:46:25.608829[Thread 0x00001cfc]:Slic3r::GUI::GuideFrame::LoadProfileFamily: parse D:\Program Files\OrcaSlicer\resources\profiles\Snapmaker.json got exception: [json.exception.type_error.304] cannot use at() with string

and please do not change the default value sparse_infill_pattern to crosshatch

SoftFever
SoftFever approved these changes Jun 21, 2024
View reviewed changes
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@SoftFever SoftFever merged commit 02a4c90 into SoftFever:main Jun 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoftFever SoftFever SoftFever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@macdylan @SoftFever