Allow Cmd-Shift-M to bring up 3dConnexion Spacemouse Dialog (EXCEPT on "Home" sub-screen)

[SuperTango]

Description

this is for issues:

• 3DConnexion dialog blocked by MainFrame eating "Cmd-Shift-M" improperly on Mac #5597,
• Adjustable speed for 3d mouse such as 3Dconnexion SpaceMouse #3645 on the mac side,
• 3DConnexion SpaceMouse control is wonky #1950 tangentially.

The problem is that hitting "Cmd-Shift-M" on mac always minimizes the app, even though it should only minimize on "Cmd-M", and not on "Cmd-Shift-M".

The code that minimizes (using the WXWidgets "Iconize()" call) happens in MainFrame.cpp keyboard event loop. The code that's checking, looks for "Cmd-M" but does not check for any other keyboard modifiers, so I added a check to ignore the event if Shift is pressed along with "Cmd-M".

There's a secondary issue that isn't really relevant to this bug in that the app will still minimize when pressing "Cmd-Shift-M", but ONLY on the "Home" sub-screen. (all other sub-screens work as they should).

I'm not sure why, but when the "Home" sub-screen is selected, the keyboard event loop (MainFrame.cpp, line 609), is called TWICE when "Cmd-Shift-" is pressed:

• Once where the event's wxKeyModifier (retrieved via evt.GetModifiers() is set to wxMOD_CONTROL AND wxMOD_SHIFT. (this is correct)
• Once where the event's wxKeyModifier is ONLY set to wxMOD_CONTROL (this is wrong).

I hunted around the code for a long while trying to figure this out, but I don't know much about wxWidgets (and the docs/googling didn't reveal anything), so I wasn't able to fix this root cause.

Again, this double-event (with the wrong modifiers) only happens when the user is on the "Home" sub-screen. For the context of this bug the 3DConnexion preferences dialog isn't needed on the "Home" sub-screen so this secondary bug doesn't really matter. But it does make the UX odd where Cmd-Shift-M will minimize the app when the user is viewing the "Home" sub-screen, but not minimize the app when the user is viewing any other sub-screen.

Screenshots/Recordings/Graphs

Tests

manual testing was done.

• On Mac, verified that the "Cmd-Shift-M" brings up the 3dConnexion dialog box and does not minimize the app (on all sub-screens except for the "Home" sub-screen as described above in the "secondary issue" above).
• On Mac, verified that bringing up the "Keyboard Shortcuts" dialog shows "Cmd-Shift-M" instead of "Cmd-M" on a mac. I do not have a windows or linux machine to test on, but it's a one-line #ifdef change, so it should be good.

[foreachthing]

Why not bring this dialog into this menu? Or, allow the user to define the shortcuts.

[SuperTango]

Why not bring this dialog into this menu? Or, allow the user to define the shortcuts.

I was merely providing a fix to the bug that prevented the 3dConnexion dialog from appearing without making any structural changes to the codebase. TBH, i'm not sure what menu you're referencing (I don't see that icon on mac), and as for letting users choose their own shortcuts, I think that's a great feature request, but that's a pretty hefty change to the codebase, which is out of scope of this bugfix.

[foreachthing]

i'm not sure what menu you're referencing

My mistake! I'm on Windows and assumed it looked the same on all OSs.

In OrcaSlicer 2.0:

In OrcaSlicer 2.1:

[SoftFever]

Looks good.
Thank you for digging into the code and fix it!