Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Variable layer height gizmo when other toolbar buttons clicked #5255

Merged
merged 1 commit into from
May 8, 2024

Conversation

yw4z
Copy link
Contributor

@yw4z yw4z commented May 3, 2024

• This allows closing when other toolbar icon clicked
• Also allows closing gizmo when its icon clicked
• Gizmo still keeps open when other areas clicked

Before (GIF)
• Clicking other gizmos not closing variable layer height and overlaps with other gizmos
orca-slicer_vyWrhY9jmU

After (GIF)
• Gizmo closes itself when other gizmos activated
orca-slicer_W3GNbExuRN

I have tried rotate while variable layer height gizmo open. but it resets it self and i guess its not a planned feature. Recommended to use as a popup window if that's used like this

What's your opinion on this?

@discip
Copy link
Contributor

discip commented May 3, 2024

@yw4z
This was one of the things I had on my list to be reported, thank you so much! 👍

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yw4z
Can I check what OS are you using?

@yw4z
Copy link
Contributor Author

yw4z commented May 7, 2024

@SoftFever windows 10

@discip
Copy link
Contributor

discip commented May 7, 2024

@SoftFever
This is also present under Linux (Manjaro Gnome).

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
Thanks

@SoftFever SoftFever merged commit 29f9d5d into SoftFever:main May 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants