Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide revert and delete preset buttons while search box focused #5253

Merged
merged 1 commit into from
May 9, 2024

Conversation

yw4z
Copy link
Contributor

@yw4z yw4z commented May 3, 2024

Before
Screenshot-20240503213414

After
Screenshot-20240503213610

I'm planning to fix all margin related problems at separate commit

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thank you

@SoftFever SoftFever merged commit 4c1b66c into SoftFever:main May 9, 2024
12 checks passed
@nevack
Copy link
Contributor

nevack commented May 9, 2024

nit: @yw4z please use consistent indentation.
You have both spaces and tabs in your change

@discip
Copy link
Contributor

discip commented May 9, 2024

@yw4z
Unfortunately this looks somewhat broken under Manjaro Gnome:

Actually, I just noticed that the top section looks completely different compared to the screenshots you posted. 🤷

image

image

@yw4z
Copy link
Contributor Author

yw4z commented May 9, 2024

@discip not sure why your search box not uses roundedcorners. it uses rounded rectangle on original source. you need to send screenshots before and after merge. and you send 2 screenschots with 2 different with for side bar.

@nevack only using space is better right? i did this commit from text editor of github my mistake on that. but ofc compiled and tested on my gui branch

@discip
Copy link
Contributor

discip commented May 9, 2024

I was not aware of the fact that this was different from the windows build prior to your change.

I intentionally took screenshots with 2 different widths of the menu to point out the difference of the dropdown in both cases.

Nonetheless here are the screenshots you asked for:

before:

image

after:

image

@yw4z
Copy link
Contributor Author

yw4z commented May 9, 2024

i look for related code and yes linux uses different sizers and input box in search.cpp (line 579) but im not sure why they do like that. so this issue not related with this commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants