Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wipe tower not showing purged filament volume for non BBL SEMM #5223

Conversation

igiannakas
Copy link
Contributor

@igiannakas igiannakas commented May 1, 2024

When using a non BBL printer (i.e. klipper or other) the wipe tower filament use statistics where displaying 0 for all filaments except one and incorrectly counting the purge volume in the wipe tower per filament. The total volume was correct though.

See below:
image
image

This PR addresses this issue by correctly tagging the start and end of the wipe tower and correctly assigning the printer type (BBL or non BBL) in the Gcode processor when the corresponding Wipe towers are initialised.

image
image

@igiannakas igiannakas mentioned this pull request May 1, 2024
@igiannakas igiannakas changed the title Fix wipe tower not showing purged filament values for non BBL SEMM Fix wipe tower not showing purged filament volume for non BBL SEMM May 1, 2024
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Nice fix!

@SoftFever SoftFever merged commit d2e7621 into SoftFever:main May 2, 2024
12 checks passed
@igiannakas
Copy link
Contributor Author

Your welcome! It was bothering me to no end after getting my ERCF setup :D

@igiannakas igiannakas deleted the Fix-wipe-tower-statistics-for-SEMM-on-non-BBL-printers branch May 2, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants